----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4991/ -----------------------------------------------------------
(Updated 2012-05-06 04:52:54.999890) Review request for rave. Changes ------- Reworked the inclusion strategy - instead of dropping in the contents of the entire bootstrap.zip file, only the less/img files are included. Also, adjusted the references to image sprites. Summary ------- This patch is the *first* step towards using LESS to compile Twitter Bootstrap together with Rave stylesheets. What it includes: - Inclusion of source Bootstrap files - LESS compilation of Bootstrap + Rave CSS (default.css and rave.css) done by wro4j - Customization-friendly separation: Rave definitions are contained in rave.less, while integrators can customize rave-customizations.less as they see fit What it DOES not include: - Factoring out "old" CSS files (although they are no longer referenced from the <head>) - Reworking actual CSS definitions - much cleanup/consolidation remains - A solution to let developers compile LESS client-side (for easier experimentation in debug mode) - Minification of CSS (would like to tackle that after we have a debug option, which will turn off minification) Diffs (updated) ----- https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/webapp/css/bootstrap/css/bootstrap.css 1334149 https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/pom.xml 1334149 https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/resources/wro.properties 1334149 https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/resources/wro.xml 1334149 https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/tags/rave_css.tag 1334149 https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/webapp/css/bootstrap/css/bootstrap-responsive.css 1334149 https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/webapp/css/bootstrap/less/accordion.less PRE-CREATION https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/webapp/css/bootstrap/less/alerts.less PRE-CREATION https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/webapp/css/bootstrap/less/bootstrap.less PRE-CREATION https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/webapp/css/bootstrap/less/breadcrumbs.less PRE-CREATION https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/webapp/css/bootstrap/less/button-groups.less PRE-CREATION https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/webapp/css/bootstrap/less/buttons.less PRE-CREATION https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/webapp/css/bootstrap/less/carousel.less PRE-CREATION https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/webapp/css/bootstrap/less/close.less PRE-CREATION https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/webapp/css/bootstrap/less/code.less PRE-CREATION https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/webapp/css/bootstrap/less/component-animations.less PRE-CREATION https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/webapp/css/bootstrap/less/dropdowns.less PRE-CREATION https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/webapp/css/bootstrap/less/forms.less PRE-CREATION https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/webapp/css/bootstrap/less/grid.less PRE-CREATION https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/webapp/css/bootstrap/less/hero-unit.less PRE-CREATION https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/webapp/css/bootstrap/less/labels-badges.less PRE-CREATION https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/webapp/css/bootstrap/less/layouts.less PRE-CREATION https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/webapp/css/bootstrap/less/mixins.less PRE-CREATION https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/webapp/css/bootstrap/less/modals.less PRE-CREATION https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/webapp/css/bootstrap/less/navbar.less PRE-CREATION https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/webapp/css/bootstrap/less/navs.less PRE-CREATION https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/webapp/css/bootstrap/less/pager.less PRE-CREATION https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/webapp/css/bootstrap/less/pagination.less PRE-CREATION https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/webapp/css/bootstrap/less/popovers.less PRE-CREATION https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/webapp/css/bootstrap/less/progress-bars.less PRE-CREATION https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/webapp/css/bootstrap/less/reset.less PRE-CREATION https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/webapp/css/bootstrap/less/responsive-1200px-min.less PRE-CREATION https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/webapp/css/bootstrap/less/responsive-767px-max.less PRE-CREATION https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/webapp/css/bootstrap/less/responsive-768px-979px.less PRE-CREATION https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/webapp/css/bootstrap/less/responsive-navbar.less PRE-CREATION https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/webapp/css/bootstrap/less/responsive-utilities.less PRE-CREATION https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/webapp/css/bootstrap/less/responsive.less PRE-CREATION https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/webapp/css/bootstrap/less/scaffolding.less PRE-CREATION https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/webapp/css/bootstrap/less/sprites.less PRE-CREATION https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/webapp/css/bootstrap/less/tables.less PRE-CREATION https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/webapp/css/bootstrap/less/thumbnails.less PRE-CREATION https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/webapp/css/bootstrap/less/tooltip.less PRE-CREATION https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/webapp/css/bootstrap/less/type.less PRE-CREATION https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/webapp/css/bootstrap/less/utilities.less PRE-CREATION https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/webapp/css/bootstrap/less/variables.less PRE-CREATION https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/webapp/css/bootstrap/less/wells.less PRE-CREATION https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/webapp/css/rave-customizations.less PRE-CREATION https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/webapp/css/rave.less PRE-CREATION Diff: https://reviews.apache.org/r/4991/diff Testing ------- Thanks, Stan
