----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4843/#review7642 -----------------------------------------------------------
Ship it! Paul, see my comment re: Sub Page Rendering...other than the minor changes I'd say this feature can be added to Rave! - Anthony On 2012-05-02 17:41:05, Paul Sharples wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4843/ > ----------------------------------------------------------- > > (Updated 2012-05-02 17:41:05) > > > Review request for rave. > > > Summary > ------- > > RAVE-103. support shared spaces. I've submitted this patch here rather than > commit the code directly, as the changes affect the UI and I wanted a request > for comments type approach first. This is a page sharing patch which allows a > user to share his/her page with other rave users, as well as also allowing > the user to revoke page shares. A user who receives a shared page can opt to > confirm the share (meaning the page will always appear in his/her tabbed page > list or decline it (i.e I don't want this shared page). There's still more > to improve on this, but the basic functionality is there. Note I have removed > the render sequencing away from the page object into the new pageUser object. > This is because with the possibility of having several users of a page, they > all need to have their own page render sequencing. See RAVE-103. > > > Diffs > ----- > > > /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/repository/PageRepository.java > 1308947 > > /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/Page.java > 1306906 > > /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/PageInvitationStatus.java > PRE-CREATION > > /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/PageUser.java > PRE-CREATION > > /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/repository/impl/JpaPageRepository.java > 1308947 > > /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/security/impl/DefaultPagePermissionEvaluator.java > 1306906 > > /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/PageService.java > 1306906 > > /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/impl/DefaultPageService.java > 1310534 > > /trunk/rave-components/rave-core/src/main/resources/META-INF/persistence.xml > 1306906 > > /trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/model/PageTest.java > 1306906 > > /trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/repository/impl/JpaPageRepositoryTest.java > 1308947 > > /trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/service/impl/DefaultPageServiceTest.java > 1327947 > /trunk/rave-components/rave-core/src/test/resources/test_data.sql 1308947 > > /trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/api/rpc/PageApi.java > 1306906 > > /trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/api/rpc/UserApi.java > PRE-CREATION > > /trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/PageController.java > 1306906 > > /trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/util/ModelKeys.java > 1331453 > > /trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/controller/PageControllerTest.java > 1330044 > /trunk/rave-portal-resources/src/main/resources/messages.properties 1330724 > /trunk/rave-portal-resources/src/main/resources/messages_nl.properties > 1327926 > /trunk/rave-portal-resources/src/main/webapp/WEB-INF/db/initial_data.sql > 1327941 > /trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/page.jsp > 1330737 > /trunk/rave-portal-resources/src/main/webapp/css/default.css 1330727 > /trunk/rave-portal-resources/src/main/webapp/script/rave_api.js 1306906 > /trunk/rave-portal-resources/src/main/webapp/script/rave_layout.js 1330737 > /trunk/rave-portal/src/test/resources/test-data.sql 1306906 > > Diff: https://reviews.apache.org/r/4843/diff > > > Testing > ------- > > > Thanks, > > Paul > >
