[
https://issues.apache.org/jira/browse/RAVE-613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13270494#comment-13270494
]
[email protected] commented on RAVE-613:
----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5061/#review7682
-----------------------------------------------------------
Ship it!
Looks good to me.
- Erin
On 2012-05-08 01:13:02, Chris Geer wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/5061/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-05-08 01:13:02)
bq.
bq.
bq. Review request for rave.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. This adds the ability to register new popup definitions to be used inside
the container. This is to overcome the issue where we can't skin the current
popups.
bq.
bq. This is my initial approach. Let me know if there is a better way to
handle this. Ref mailing list discussion at:
http://markmail.org/thread/nipyntndlktosi67
bq.
bq.
bq. This addresses bug RAVE-613.
bq. https://issues.apache.org/jira/browse/RAVE-613
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. /trunk/rave-portal-resources/src/main/webapp/script/rave.js 1335243
bq.
bq. Diff: https://reviews.apache.org/r/5061/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. This capability requires having custom js so it isn't able to test as part
of the standard rave install. I use the files below to register my popup which
works. Then I use a modified open_views gadget to load it. The JS below needs
to be loaded through the custom_js.tag mechanism into the container.
bq.
bq. var rave = rave || {};
bq.
bq. var fullwidth_dialog = {
bq. name:"dialog",
bq. containerSelector:'.popup.dialog',
bq. contentSelector:'.modal-body',
bq. markup:'<div class="popup dialog modal fade"><div
class="modal-body"></div></div>',
bq. initialize:function (container) {
bq. container.find(this.contentSelector).data('popupType',
this.name);
bq. var cfg = {
bq. };
bq. container.modal(cfg);
bq.
bq. container.on('hidden', function () {
bq. container.detach();
bq. })
bq. },
bq. cleanup:function (content) {
bq. var container = content.parents(this.containerSelector);
bq.
bq. container.modal('hide');
bq. },
bq. singleton:false
bq. };
bq.
bq. rave.registerPopup("fullwidth_dialog", fullwidth_dialog);
bq.
bq.
bq. Thanks,
bq.
bq. Chris
bq.
bq.
> Support registering custom popup types with the container
> ---------------------------------------------------------
>
> Key: RAVE-613
> URL: https://issues.apache.org/jira/browse/RAVE-613
> Project: Rave
> Issue Type: Improvement
> Components: rave-portal
> Reporter: Chris Geer
>
> Right now the popup types are hardcoded in the rave.js. We need to support
> integrators defining their own custom popup types since there is no way to
> dynamically skin the popups at the gadget level.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
