----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5329/#review8290 -----------------------------------------------------------
Aaron, there seems to be something wrong with the patch file. Each file's diff is in there twice, can you fix and repost? Also, It looks like you added @Ignore to a bunch of tests. Was it intentional to check in those changes? - Chris On 2012-06-01 13:38:24, Aaron Gooch wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5329/ > ----------------------------------------------------------- > > (Updated 2012-06-01 13:38:24) > > > Review request for rave. > > > Summary > ------- > > Update Tag and WidgetTag to interfaces. Created JpaTag, TagImpl and > JpaWidgetTag, WidgetTagImpl. Refactored code base to support changes. > > > This addresses bug Rave-632. > https://issues.apache.org/jira/browse/Rave-632 > > > Diffs > ----- > > > branches/model_interfaces/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/JpaTag.java > PRE-CREATION > > branches/model_interfaces/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/JpaWidgetTag.java > PRE-CREATION > > branches/model_interfaces/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/JpaWidgetTag.java > PRE-CREATION > > branches/model_interfaces/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/Tag.java > 1345085 > > branches/model_interfaces/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/Tag.java > 1345085 > > branches/model_interfaces/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/TagImpl.java > PRE-CREATION > > branches/model_interfaces/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/TagImpl.java > PRE-CREATION > > branches/model_interfaces/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/Widget.java > 1345085 > > branches/model_interfaces/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/Widget.java > 1345085 > > branches/model_interfaces/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/WidgetTag.java > 1345085 > > branches/model_interfaces/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/WidgetTag.java > 1345085 > > branches/model_interfaces/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/WidgetTagImpl.java > PRE-CREATION > > branches/model_interfaces/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/conversion/JpaGroupConverter.java > 1345085 > > branches/model_interfaces/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/conversion/JpaGroupConverter.java > 1345085 > > branches/model_interfaces/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/conversion/JpaTagConverter.java > PRE-CREATION > > branches/model_interfaces/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/conversion/JpaTagConverter.java > PRE-CREATION > > branches/model_interfaces/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/conversion/JpaWidgetTagConverter.java > PRE-CREATION > > branches/model_interfaces/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/conversion/JpaWidgetTagConverter.java > PRE-CREATION > > branches/model_interfaces/rave-components/rave-core/src/main/java/org/apache/rave/portal/repository/TagRepository.java > 1345085 > > branches/model_interfaces/rave-components/rave-core/src/main/java/org/apache/rave/portal/repository/TagRepository.java > 1345085 > > branches/model_interfaces/rave-components/rave-core/src/main/java/org/apache/rave/portal/repository/WidgetTagRepository.java > 1345085 > > branches/model_interfaces/rave-components/rave-core/src/main/java/org/apache/rave/portal/repository/WidgetTagRepository.java > 1345085 > > branches/model_interfaces/rave-components/rave-core/src/main/java/org/apache/rave/portal/repository/impl/JpaTagRepository.java > 1345085 > > branches/model_interfaces/rave-components/rave-core/src/main/java/org/apache/rave/portal/repository/impl/JpaTagRepository.java > 1345085 > > branches/model_interfaces/rave-components/rave-core/src/main/java/org/apache/rave/portal/repository/impl/JpaWidgetTagRepository.java > 1345085 > > branches/model_interfaces/rave-components/rave-core/src/main/java/org/apache/rave/portal/repository/impl/JpaWidgetTagRepository.java > 1345085 > > branches/model_interfaces/rave-components/rave-core/src/main/java/org/apache/rave/portal/security/impl/DefaultWidgetTagPermissionEvaluator.java > 1345085 > > branches/model_interfaces/rave-components/rave-core/src/main/java/org/apache/rave/portal/security/impl/DefaultWidgetTagPermissionEvaluator.java > 1345085 > > branches/model_interfaces/rave-components/rave-core/src/main/resources/META-INF/persistence.xml > 1345085 > > branches/model_interfaces/rave-components/rave-core/src/test/java/org/apache/rave/portal/model/TagTest.java > 1345085 > > branches/model_interfaces/rave-components/rave-core/src/test/java/org/apache/rave/portal/model/TagTest.java > 1345085 > > branches/model_interfaces/rave-components/rave-core/src/test/java/org/apache/rave/portal/model/WidgetTagTest.java > 1345085 > > branches/model_interfaces/rave-components/rave-core/src/test/java/org/apache/rave/portal/model/WidgetTagTest.java > 1345085 > > branches/model_interfaces/rave-components/rave-core/src/test/java/org/apache/rave/portal/model/conversion/JpaGroupConverterTest.java > 1345085 > > branches/model_interfaces/rave-components/rave-core/src/test/java/org/apache/rave/portal/model/conversion/JpaGroupConverterTest.java > 1345085 > > branches/model_interfaces/rave-components/rave-core/src/test/java/org/apache/rave/portal/model/conversion/JpaTagConverterTest.java > PRE-CREATION > > branches/model_interfaces/rave-components/rave-core/src/test/java/org/apache/rave/portal/model/conversion/JpaTagConverterTest.java > PRE-CREATION > > branches/model_interfaces/rave-components/rave-core/src/test/java/org/apache/rave/portal/model/conversion/JpaWidgetTagConverterTest.java > PRE-CREATION > > branches/model_interfaces/rave-components/rave-core/src/test/java/org/apache/rave/portal/model/conversion/JpaWidgetTagConverterTest.java > PRE-CREATION > > branches/model_interfaces/rave-components/rave-core/src/test/java/org/apache/rave/portal/repository/AbstractJpaRepositoryTest.java > 1345085 > > branches/model_interfaces/rave-components/rave-core/src/test/java/org/apache/rave/portal/repository/AbstractJpaRepositoryTest.java > 1345085 > > branches/model_interfaces/rave-components/rave-core/src/test/java/org/apache/rave/portal/repository/impl/JpaTagRepositoryTest.java > 1345085 > > branches/model_interfaces/rave-components/rave-core/src/test/java/org/apache/rave/portal/repository/impl/JpaTagRepositoryTest.java > 1345085 > > branches/model_interfaces/rave-components/rave-core/src/test/java/org/apache/rave/portal/repository/impl/JpaWidgetTagRepositoryTest.java > 1345085 > > branches/model_interfaces/rave-components/rave-core/src/test/java/org/apache/rave/portal/repository/impl/JpaWidgetTagRepositoryTest.java > 1345085 > > branches/model_interfaces/rave-components/rave-core/src/test/java/org/apache/rave/portal/service/impl/DefaultTagServiceTest.java > 1345085 > > branches/model_interfaces/rave-components/rave-core/src/test/java/org/apache/rave/portal/service/impl/DefaultTagServiceTest.java > 1345085 > > branches/model_interfaces/rave-components/rave-core/src/test/java/org/apache/rave/portal/service/impl/DefaultWidgetTagServiceTest.java > 1345085 > > branches/model_interfaces/rave-components/rave-core/src/test/java/org/apache/rave/portal/service/impl/DefaultWidgetTagServiceTest.java > 1345085 > > branches/model_interfaces/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/api/rest/WidgetApi.java > 1345085 > > branches/model_interfaces/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/api/rest/WidgetApiTest.java > 1345085 > > branches/model_interfaces/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/controller/WidgetStoreControllerTest.java > 1345085 > > Diff: https://reviews.apache.org/r/5329/diff > > > Testing > ------- > > > Thanks, > > Aaron > >
