-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5446/
-----------------------------------------------------------

(Updated June 20, 2012, 4:22 p.m.)


Review request for rave.


Description
-------

I updated Rave to work with beta2. GroupId changed quite a bit so the changes I 
made were enough to pass the tests but I'm not 100% sure they are the right 
long term fix. We probably need to migrate away from using Strings for group ID 
in the code.


This addresses bug RAVE-685.
    https://issues.apache.org/jira/browse/RAVE-685


Diffs
-----

  /trunk/pom.xml 1348273 
  /trunk/rave-portal-resources/src/main/webapp/script/rave_opensocial.js 
1348273 
  
/trunk/rave-providers/rave-opensocial-provider/rave-opensocial-core/src/main/java/org/apache/rave/opensocial/service/impl/DefaultPersonService.java
 1348273 
  
/trunk/rave-providers/rave-opensocial-provider/rave-opensocial-core/src/test/java/org/apache/rave/opensocial/service/PersonServiceTest.java
 1348273 
  
/trunk/rave-providers/rave-opensocial-provider/rave-opensocial-server/rave-shindig/src/main/resources/rave.shindig.properties
 1348273 

Diff: https://reviews.apache.org/r/5446/diff/


Testing
-------

Ran all unit tests (all passed up until the Javascript tests in 
rave-portal-resources. These fail due to the changes in how the rpchooks are 
now registered). Ran the container and the basics worked. Jasha, can you look 
at the JS tests?


Thanks,

Chris Geer

Reply via email to