-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5807/#review8917
-----------------------------------------------------------

Ship it!


Even there is duplication of some code but it should work until we find out how 
to pass pageid before login to rave. I will apply the patch if there is no 
objections

- Raminder Singh


On July 6, 2012, 2:49 p.m., Viknes B wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5807/
> -----------------------------------------------------------
> 
> (Updated July 6, 2012, 2:49 p.m.)
> 
> 
> Review request for rave and Raminder Singh.
> 
> 
> Description
> -------
> 
> The create account button is again displayed in the create account page. It 
> should be removed. Similar changes in other pages should also be removed
> 
> 
> This addresses bug Rave-657.
>     https://issues.apache.org/jira/browse/Rave-657
> 
> 
> Diffs
> -----
> 
>   
> https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/newaccount.jsp
>  1357936 
>   
> https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/newpassword.jsp
>  1357936 
>   
> https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/retrieveusername.jsp
>  1357936 
> 
> Diff: https://reviews.apache.org/r/5807/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Viknes B
> 
>

Reply via email to