----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6154/#review9560 -----------------------------------------------------------
One minor issue. We want to keep logic in the script blocks on page light; but want to ensure we are keeping good separation of concerns as well. trunk/rave-portal-resources/src/main/webapp/static/script/rave.js <https://reviews.apache.org/r/6154/#comment20419> To be consistent with the rest of the application flow, I would move this logic back to the script block. initializing the UI, pageLayouts, etc should be managed by the object being rendered (IE the page) - Matt Franklin On July 27, 2012, 5:18 p.m., Daniel Gornstein wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6154/ > ----------------------------------------------------------- > > (Updated July 27, 2012, 5:18 p.m.) > > > Review request for rave. > > > Description > ------- > > For this fix I have added code to hide the region with the content of the > page until accept is pressed. After accept is pressed on the callback it > reloads the page which shows the content of the page. If I just did a .show() > the resizing of the gadgets was not correct. > > > Diffs > ----- > > trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/page.jsp > 1365541 > trunk/rave-portal-resources/src/main/webapp/static/script/rave.js 1365541 > trunk/rave-portal-resources/src/main/webapp/static/script/rave_layout.js > 1365541 > > Diff: https://reviews.apache.org/r/6154/diff/ > > > Testing > ------- > > > Thanks, > > Daniel Gornstein > >
