----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6444/#review9993 -----------------------------------------------------------
trunk/rave-portal-resources/src/main/webapp/WEB-INF/tags/rave_js.tag <https://reviews.apache.org/r/6444/#comment21167> Minor nit, just fix the indenting to show these statements happen within the context of the <sec:authorize> trunk/rave-portal-resources/src/main/webapp/static/script/rave.js <https://reviews.apache.org/r/6444/#comment21170> Since pageOwner is currently only set on the profile page, would it be better to return a valid default object like {username: "Unknown", id:"-1"} or something rather than undefined/null? trunk/rave-portal-resources/src/main/webapp/static/script/rave.js <https://reviews.apache.org/r/6444/#comment21168> I would prefer to see the method name match the variable so setViewer becomes setPageViewer (same change on other method names. trunk/rave-portal-resources/src/main/webapp/static/script/rave.js <https://reviews.apache.org/r/6444/#comment21169> Does it make sense to update the documentation here to describe the expected/returned object? - Chris Geer On Aug. 7, 2012, 7:12 p.m., Erin Noe-Payne wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6444/ > ----------------------------------------------------------- > > (Updated Aug. 7, 2012, 7:12 p.m.) > > > Review request for rave. > > > Description > ------- > > Adds the concept of page viewer and owner to the client at the container > level. Page viewer is defined as the authenticated user viewing a page, owner > is left to be defined on a per-page basis. > > > This addresses bug RAVE-751. > https://issues.apache.org/jira/browse/RAVE-751 > > > Diffs > ----- > > > trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/personProfile.jsp > 1370376 > trunk/rave-portal-resources/src/main/webapp/WEB-INF/tags/rave_js.tag > 1370376 > trunk/rave-portal-resources/src/main/webapp/static/script/rave.js 1370376 > > Diff: https://reviews.apache.org/r/6444/diff/ > > > Testing > ------- > > > Thanks, > > Erin Noe-Payne > >
