[ 
https://issues.apache.org/jira/browse/RAVE-760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13437923#comment-13437923
 ] 

Chris Geer commented on RAVE-760:
---------------------------------

1) If we could make it configurable I don't think it would be an issue but 
since we can't pass options to this capability as it stands I don't know if we 
want ALL dialogs to have this button.

2) When the original plan for the OpenViews stuff went in, it was based on 
jQuery but the decision was to remove that and use bootstrap for both (Even 
though as you point out bootstrap doesn't actually support modeless dialogs). 
To allow implementers some flexibility we did RAVE-613 which allows you to use 
custom popup definitions (i.e. dialogs) instead of the bootstrap ones. We 
actually use jQuery popups with close buttons in our app so I know it's 
possible to solve these problems. 

So, I think the capability exists to handle both these issues today without any 
changes, it's just not the default option of the container.
                
> Dialog and ModalDialog views - Differentiate and add explcit close
> ------------------------------------------------------------------
>
>                 Key: RAVE-760
>                 URL: https://issues.apache.org/jira/browse/RAVE-760
>             Project: Rave
>          Issue Type: Story
>          Components: rave-opensocial-provider
>    Affects Versions: 0.14
>            Reporter: Marsha Nunes
>            Priority: Minor
>
> -DIALOG and MODALDIALOG  currently behave the same way.  Change DIALOG to be 
> a modeless dialog - no lightbox and the user can interact with the page 
> below.  
> See jQueryUI for examples of modeless (their default) vs. modal: 
> http://jqueryui.com/demos/dialog/#default
> -Add a close icon/button to both of these views.  (Needed for modeless and 
> will increase usability of modal.)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to