> On Aug. 21, 2012, 8:19 p.m., Raminder Singh wrote: > > Patch worked well after cleaning my chrome cache. Problem i am facing is > > for rave-openid usser. Add friend does not work as openid is a URL. I tried > > to use encodeURIComponent(username) in rave_api and rave_person_profile but > > i get error failed to find PersonApi service. I will recommend we use > > userid to avoid such problem.
There would be a problem using userid because we would be dealing with Person objects in most of these methods and Person objects as per openId specs would not contain usedId(entityId). So i guess we are left with the option of encoding the username and passing it. - Viknes ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6681/#review10589 ----------------------------------------------------------- On Aug. 17, 2012, 10:10 p.m., Viknes B wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6681/ > ----------------------------------------------------------- > > (Updated Aug. 17, 2012, 10:10 p.m.) > > > Review request for rave. > > > Description > ------- > > Sending/ Accepting/ Declining friend requests to users in Rave. > Did some code clean up as well. > > > This addresses bug Rave-761. > https://issues.apache.org/jira/browse/Rave-761 > > > Diffs > ----- > > > https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/FriendRequestStatus.java > 1372556 > > https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/repository/PersonRepository.java > 1372556 > > https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/UserService.java > 1372556 > > https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/impl/DefaultUserService.java > 1372556 > > https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/model/JpaPersonAssociation.java > 1372556 > > https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/repository/impl/JpaPersonRepository.java > 1372556 > > https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-jpa/src/test/java/org/apache/rave/portal/repository/impl/JpaPersonRepositoryTest.java > 1372556 > > https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/api/rpc/PersonApi.java > 1372556 > > https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/ProfileController.java > 1372556 > > https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/controller/ProfileControllerTest.java > 1372556 > > https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/resources/messages.properties > 1372556 > > https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/tags/navbar.tag > 1372556 > > https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/webapp/static/script/rave_api.js > 1372556 > > https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/webapp/static/script/rave_person_profile.js > 1372556 > > https://svn.apache.org/repos/asf/rave/trunk/rave-providers/rave-opensocial-provider/rave-opensocial-core/src/main/java/org/apache/rave/opensocial/repository/impl/DecoratingOpenSocialPersonRepository.java > 1372556 > > Diff: https://reviews.apache.org/r/6681/diff/ > > > Testing > ------- > > > Thanks, > > Viknes B > >
