Keep up the good work Viknes :) Not all Rave usernames have a dot in them (canonical, johnldap). Most do, but that's pure coincidental. If you strip http(s):// from the openid url, also convert the / into a different character.
The OpenId login should also be checked against the OpenId field, not the username. The OpenId accounts should not be able to log in with their username + some password in the login form of the portal (which is possible at the moment). On 24 August 2012 20:59, Viknes B <[email protected]> wrote: > I can have a look at it. > Given that rave usernames already have .(dot) in them, I suggest we can > just strip the 'http://' in the beginning and end so that we can use it > as a username and have the openID url saved in a separate field. > > Viknes > On 24 Aug 2012, at 14:52, Jasha Joachimsthal wrote: > > > I once started working on provisioning OpenId users, but didn't finish it > > because I ran into several issues I couldn't solve that time. The OpenId > > URL was stored in the openid field of the User and the last part of the > url > > was used as username. It probably needs more finetuning because the last > > part is probably not unique. > > You can find the work in progress as patch in > > https://issues.apache.org/jira/browse/RAVE-677 > > > > On 24 August 2012 20:44, Raminderjeet Singh <[email protected] > >wrote: > > > >> We identified this problem while dealing with Add/Remove Friends and > there > >> we did not have userid so we ended up encoding/decoding URL. That can > give > >> some problem in future on different browsers. > >> > >> +1 to get username from OpenID provider if possible. > >> > >> Thanks > >> Raminder > >> > >> On Aug 24, 2012, at 2:38 PM, Chris Geer wrote: > >> > >>> On Fri, Aug 24, 2012 at 11:27 AM, Jasha Joachimsthal <[email protected] > >>> wrote: > >>> > >>>> I ran into the same issue as Raminder before with the OpenId url as > >>>> username. In case of OpenId we should think of different usernames > than > >> the > >>>> URL (in the model there is a separate field for the OpenId url, but > it's > >>>> not being used). > >>>> > >>> > >>> +1 - When they first register on Rave, can we collect a username to map > >> to > >>> that OpenID user? > >>> > >>>> > >>>> Jasha > >>>> > >>>> On 24 August 2012 17:56, Raminderjeet Singh <[email protected] > >>>>> wrote: > >>>> > >>>>> Sure i can make the change. I did not find any reference where > >>>>> /person/username was used so want with the change. > >>>>> > >>>>> Thanks > >>>>> Raminder > >>>>> > >>>>> On Aug 24, 2012, at 11:27 AM, Carlucci, Tony wrote: > >>>>> > >>>>>> Sorry for the potential duplicate email but it appears Jira's > comment > >>>>> emailer is not working due to maintenance... > >>>>>> > >>>>>> Hi Raminder, I believe it's a necessity in Rave for a Person Profile > >>>>> page to be accessible via a username. Can you please revert the > >> existing > >>>>> PersonController viewProfile function back, and create a second > >>>> controller > >>>>> endpoint which can be accessible via the id? That way it would serve > >> both > >>>>> needs. Perhaps /person/id/{id} ? > >>>>>> > >>>>>> -1 on this commit (1376704) > >>>>>> > >>>>>> Others have comments? > >>>>>> > >>>>>> Thanks, Tony > >>>>> > >>>>> > >>>> > >> > >> > >
