----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6960/#review11175 -----------------------------------------------------------
Kristen, this ticket was originally part of RAVE-760 where there was a comment about making the close button optional (from me). It would be preferably to find a way to make the dialog configurable in a way that would allow people to set the option when showing a dialog but I don't think we have a way to do that yet. Maybe the alternative is to have two sets of dialog configs, one with close icons and one without. The use case is if you have special processing on the close of the dialog, with this change there is no way to enforce that as far as I can see. Thoughts? We really need to have dialogs be more configurable at runtime. I'm doing it now through some RPC calls but it's not 100% ideal. Maybe we can come up with a better solution. - Chris Geer On Sept. 7, 2012, 7:02 p.m., Kristen Legacy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6960/ > ----------------------------------------------------------- > > (Updated Sept. 7, 2012, 7:02 p.m.) > > > Review request for rave. > > > Description > ------- > > Added close button to dialog & modalDialog views. > > https://issues.apache.org/jira/browse/RAVE-790 > > > Diffs > ----- > > /trunk/rave-portal-resources/src/main/webapp/static/css/rave-css.less > 1382064 > /trunk/rave-portal-resources/src/main/webapp/static/script/rave.js 1382064 > > Diff: https://reviews.apache.org/r/6960/diff/ > > > Testing > ------- > > > Thanks, > > Kristen Legacy > >
