On 17 September 2012 12:48, Paul Sharples <[email protected]> wrote:
> On 17/09/2012 11:39, Jasha Joachimsthal wrote: > >> On 17 September 2012 12:31, <[email protected]> wrote: >> >> Author: psharples >>> Date: Mon Sep 17 10:31:01 2012 >>> New Revision: 1386545 >>> >>> URL: >>> http://svn.apache.org/viewvc?**rev=1386545&view=rev<http://svn.apache.org/viewvc?rev=1386545&view=rev> >>> Log: >>> Commented out reference to wookie API call not yet available. >>> >>> Modified: >>> >>> rave/trunk/rave-providers/**rave-w3c-provider/src/main/** >>> java/org/apache/rave/provider/**w3c/service/impl/** >>> WookieWidgetService.java >>> >>> Modified: >>> rave/trunk/rave-providers/**rave-w3c-provider/src/main/** >>> java/org/apache/rave/provider/**w3c/service/impl/** >>> WookieWidgetService.java >>> URL: >>> http://svn.apache.org/viewvc/**rave/trunk/rave-providers/** >>> rave-w3c-provider/src/main/**java/org/apache/rave/provider/** >>> w3c/service/impl/**WookieWidgetService.java?rev=** >>> 1386545&r1=1386544&r2=1386545&**view=diff<http://svn.apache.org/viewvc/rave/trunk/rave-providers/rave-w3c-provider/src/main/java/org/apache/rave/provider/w3c/service/impl/WookieWidgetService.java?rev=1386545&r1=1386544&r2=1386545&view=diff> >>> >>> ==============================**==============================** >>> ================== >>> --- >>> rave/trunk/rave-providers/**rave-w3c-provider/src/main/** >>> java/org/apache/rave/provider/**w3c/service/impl/** >>> WookieWidgetService.java >>> (original) >>> +++ >>> rave/trunk/rave-providers/**rave-w3c-provider/src/main/** >>> java/org/apache/rave/provider/**w3c/service/impl/** >>> WookieWidgetService.java >>> Mon Sep 17 10:31:01 2012 >>> @@ -98,7 +98,9 @@ public class WookieWidgetService impleme >>> throw new WookieConnectorException("**Either the >>> wookie >>> username or password is not defined in portal.properties", null); >>> } >>> connectorService = getWookieConnectorService(** >>> wookieServerUrl, >>> wookieApiKey, ""); >>> - org.apache.wookie.connector.**framework.Widget >>> wookieWidget = >>> connectorService.postWidget(**widgetUrl, adminUsername, adminPassword); >>> + // TODO - replace dummy line below with the commented out >>> version, when bundled with wookie 0.13.0 >>> + //org.apache.wookie.connector.**framework.Widget >>> wookieWidget = >>> connectorService.postWidget(**widgetUrl, adminUsername, adminPassword); >>> + org.apache.wookie.connector.**framework.Widget >>> wookieWidget = >>> new org.apache.wookie.connector.**framework.Widget(widgetUrl, widgetUrl, >>> widgetUrl, null, widgetUrl, widgetUrl, widgetUrl, widgetUrl, widgetUrl); >>> >>> ^^^^^^^^^ >> Looks like a useless call on the constructor >> >> >> widget = new W3CWidget(); >>> widget.setUrl(wookieWidget.**getIdentifier()); >>> widget.setDescription(**wookieWidget.getDescription())**; >>> >> > Sorry my bad. I realised after the initial commit that the call I was > making here was not yet available in the wookie connector (& wouldn't > compile). So I put that dummy call in for now. > It should compile now (does for me now). I'll update the parameter names > to be more meaningful. > > Paul > Thank you (: > > >>> >>> >> >> ----- >> No virus found in this message. >> Checked by AVG - www.avg.com >> Version: 2012.0.2221 / Virus Database: 2437/5271 - Release Date: 09/16/12 >> > >
