----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8005/#review13392 -----------------------------------------------------------
IMO, I think this needs to be a local repository function. We don't expose the concept of PersonAssociation through the Model interfaces and it doesn't seem to make sense that we would not rely on the repository to actually ensure an object is removed. - Matt Franklin On Nov. 10, 2012, 2:02 a.m., Viknes B wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8005/ > ----------------------------------------------------------- > > (Updated Nov. 10, 2012, 2:02 a.m.) > > > Review request for rave. > > > Description > ------- > > Inserted a delete query to remove associations of a particular user when > deleting the user. > > > This addresses bug Rave-845. > https://issues.apache.org/jira/browse/Rave-845 > > > Diffs > ----- > > > https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/repository/PersonRepository.java > 1406782 > > https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/impl/DefaultUserService.java > 1406782 > > https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/model/JpaPersonAssociation.java > 1406782 > > https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/repository/impl/JpaPersonRepository.java > 1406782 > > https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-jpa/src/test/java/org/apache/rave/portal/repository/impl/JpaPersonRepositoryTest.java > 1406782 > > https://svn.apache.org/repos/asf/rave/trunk/rave-providers/rave-opensocial-provider/rave-opensocial-core/src/main/java/org/apache/rave/opensocial/repository/impl/DecoratingOpenSocialPersonRepository.java > 1406782 > > Diff: https://reviews.apache.org/r/8005/diff/ > > > Testing > ------- > > > Thanks, > > Viknes B > >
