----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8317/#review14102 -----------------------------------------------------------
trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/ProfileController.java <https://reviews.apache.org/r/8317/#comment30173> Not critical, but it would probably be best to throw a not found exception and use spring's exeception view resolver to return the desired page trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/ProfileController.java <https://reviews.apache.org/r/8317/#comment30174> duplicated code. separate into helper method - Matt Franklin On Dec. 6, 2012, 3:14 p.m., Aaron Gooch wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8317/ > ----------------------------------------------------------- > > (Updated Dec. 6, 2012, 3:14 p.m.) > > > Review request for rave. > > > Description > ------- > > This is a small change to the person controller. I have added the proper > response code of 404 for user not found and added a logging statement in the > event there was an unexpected exception thrown (I believe the expectation was > the user was null). > > > This addresses bug RAVE-848. > https://issues.apache.org/jira/browse/RAVE-848 > > > Diffs > ----- > > > trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/ProfileController.java > 1415304 > > trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/controller/ProfileControllerTest.java > 1415304 > > Diff: https://reviews.apache.org/r/8317/diff/ > > > Testing > ------- > > > Thanks, > > Aaron Gooch > >
