----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9100/#review16299 -----------------------------------------------------------
I am able to test the patch and it worked well. I have concerned about the amount of changes needed to pass the reference id. I know we are following similar approach in Widget store. Can we find a better solution to pass parameter around? Something in the user session context etc. Ideas? I am ok to apply this patch and create a new task to think about improvement. Thoughts? - Raminder Singh On Feb. 7, 2013, 6:39 p.m., Eduardo Romeiro wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9100/ > ----------------------------------------------------------- > > (Updated Feb. 7, 2013, 6:39 p.m.) > > > Review request for rave. > > > Description > ------- > > When returning from Admin Interface, user is now sent back to the original > work space they came from. The admin controllers were changed to request the > referring page id parameter and to add it to the model where appropriate. > > > This addresses bug RAVE-829. > https://issues.apache.org/jira/browse/RAVE-829 > > > Diffs > ----- > > > /trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/admin/AdminControllerUtil.java > 1433501 > > /trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/admin/AdminHomeController.java > 1433501 > > /trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/admin/CategoryController.java > 1433501 > > /trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/admin/PortalPreferenceController.java > 1433501 > > /trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/admin/UserController.java > 1433501 > > /trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/admin/WidgetController.java > 1433501 > > /trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/util/ControllerUtils.java > 1433501 > > /trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/controller/admin/AdminHomeControllerTest.java > 1433501 > > /trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/controller/admin/CategoryControllerTest.java > 1433501 > > /trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/controller/admin/PortalPreferenceControllerTest.java > 1433501 > > /trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/controller/admin/UserControllerTest.java > 1433501 > > /trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/controller/admin/WidgetControllerTest.java > 1433501 > > /trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/admin/categories.jsp > 1433501 > > /trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/admin/categoryDetail.jsp > 1433501 > > /trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/admin/newaccount.jsp > 1433501 > > /trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/admin/preferencedetail.jsp > 1433501 > > /trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/admin/preferences.jsp > 1433501 > > /trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/admin/userdetail.jsp > 1433501 > > /trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/admin/users.jsp > 1433501 > > /trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/admin/widgetdetail.jsp > 1433501 > > /trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/admin/widgets.jsp > 1433501 > > /trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/includes/new_user_form.jsp > 1433501 > /trunk/rave-portal-resources/src/main/webapp/WEB-INF/tags/admin_paging.tag > 1433501 > > Diff: https://reviews.apache.org/r/9100/diff/ > > > Testing > ------- > > tests were added to the admin contollers to make sure the model had the > referring page attribute. I logged into the rave and tested the functionality > as well. > > > Thanks, > > Eduardo Romeiro > >
