Erin Noe-Payne created RAVE-890:
-----------------------------------
Summary: Refactor SearchHandler
Key: RAVE-890
URL: https://issues.apache.org/jira/browse/RAVE-890
Project: Rave
Issue Type: Improvement
Reporter: Erin Noe-Payne
Priority: Minor
rave.layout.SearchHandler needs a refactor
- holds private variables in closure but does not use, instead assigns data to
"this" object, which actually works only by accident and exposes private data
- keys inconsistently off both username and userid. should be userid only
- confusing data representation of existing members. one falsey value
(undefined) means user does not have share, another falsey value (false) means
user has share but not edit rights. this is a likely source of unintended
behavior and also forces functions to use less performant for / in loops to
find values
- search handler is being fed existing members through the jsp at page render.
for pages with many shares this is cost paid on every page load for a rarely
used function. Page sharing data should probably be handled through an api and
retrieved on as-needed basis.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
