----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9959/#review18053 -----------------------------------------------------------
Looks good. IMO we should continue on this path. One general thought: I have been thinking about how to provide a default app context that makes sense, while still allowing easy modification in custom installs. What I have come up with is this: 1) Define a basic appContext in the package itself (as Jasha did with Jpa a while ago) 2) Import this into an overridable secondary context in rave-portal-resources (see dataContext.xml) 3) Import the overridable context in the core applicationContext for rave-portal-resources Though this is extra config on our side, it allows us to easily document 1) how to use the api jar in your own application (import context & add servlet) 2) how to override the current configuration in a portal that overlays rave-portal-resources without having to overlay the applicationContext itself. - Matt Franklin On March 15, 2013, 6:52 p.m., Chris Geer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9959/ > ----------------------------------------------------------- > > (Updated March 15, 2013, 6:52 p.m.) > > > Review request for rave. > > > Description > ------- > > ** This is not meant to be a final release. Just posting this so people can > see/comment on the direction ** > > Creating new web services using CXF. New service is accessible at > http://localhost:8080/portal/api/rest/ > > http://localhost:8080/portal/api/rest/people > http://localhost:8080/portal/api/rest/people/123 > http://localhost:8080/portal/api/rest/people/123/friends > > As part of this I'm using the new proposed package structure where base > functionality would move to org.apache.rave and leave org.apache.rave.portal > to the portal implementation on top of the core. There is also a new module > called rave-core-api which will hold the API. > > > This addresses bug RAVE-910. > https://issues.apache.org/jira/browse/RAVE-910 > > > Diffs > ----- > > /trunk/pom.xml 1453622 > /trunk/rave-components/pom.xml 1453622 > /trunk/rave-components/rave-core-api/pom.xml PRE-CREATION > > /trunk/rave-components/rave-core-api/src/main/java/org/apache/rave/rest/PeopleResource.java > PRE-CREATION > /trunk/rave-components/rave-core/pom.xml 1453622 > > /trunk/rave-components/rave-core/src/main/java/org/apache/rave/rest/impl/DefaultPeopleResource.java > PRE-CREATION > /trunk/rave-portal-dependencies/pom.xml 1453622 > /trunk/rave-portal-resources/pom.xml 1453622 > /trunk/rave-portal-resources/src/main/webapp/WEB-INF/applicationContext.xml > 1453622 > > /trunk/rave-portal-resources/src/main/webapp/WEB-INF/cxf-applicationContext.xml > PRE-CREATION > /trunk/rave-portal-resources/src/main/webapp/WEB-INF/web.xml 1453622 > > Diff: https://reviews.apache.org/r/9959/diff/ > > > Testing > ------- > > > Thanks, > > Chris Geer > >
