----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12088/#review22373 -----------------------------------------------------------
Ship it! We will want to set this up so we can unit test each module in isolation and inject mock dependencies. Once that is in place, we won't need most of the test dependency libraries that were added here - probably no more than underscore & require.js. - Erin Noe-Payne On June 25, 2013, 9:12 p.m., Rohit Kalkur wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12088/ > ----------------------------------------------------------- > > (Updated June 25, 2013, 9:12 p.m.) > > > Review request for rave. > > > Bugs: RAVE-979 > https://issues.apache.org/jira/browse/RAVE-979 > > > Repository: rave > > > Description > ------- > > Setting up project to use Jasmine BDD and configuring it to use Require.js to > load test specs and application code modules. > > > Diffs > ----- > > /branches/require/rave-portal-resources/pom.xml 1496570 > > /branches/require/rave-portal-resources/src/main/webapp/static/script/app.js > 1496570 > > /branches/require/rave-portal-resources/src/main/webapp/static/script/core/main.js > 1496570 > /branches/require/rave-portal-resources/src/test/customJasmineConfig.txt > PRE-CREATION > /branches/require/rave-portal-resources/src/test/dependencies/backbone.js > PRE-CREATION > /branches/require/rave-portal-resources/src/test/dependencies/bootstrap.js > PRE-CREATION > /branches/require/rave-portal-resources/src/test/dependencies/jquery.js > PRE-CREATION > > /branches/require/rave-portal-resources/src/test/dependencies/jqueryHashChange.js > PRE-CREATION > /branches/require/rave-portal-resources/src/test/dependencies/jqueryUI.js > PRE-CREATION > /branches/require/rave-portal-resources/src/test/dependencies/require.js > PRE-CREATION > > /branches/require/rave-portal-resources/src/test/javascript/rave_api_spec.js > 1496570 > /branches/require/rave-portal/pom.xml 1496570 > > Diff: https://reviews.apache.org/r/12088/diff/ > > > Testing > ------- > > > Thanks, > > Rohit Kalkur > >
