----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13111/#review24347 -----------------------------------------------------------
I don't think that getCountAll is needed on the service layer. It is just used for pagination data as part of the search results object. - Erin Noe-Payne On July 31, 2013, 12:44 p.m., Daniel Gornstein wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13111/ > ----------------------------------------------------------- > > (Updated July 31, 2013, 12:44 p.m.) > > > Review request for rave. > > > Repository: rave > > > Description > ------- > > RAVE 1010 - Update service layers to support crud operations from REST api > > > Diffs > ----- > > > /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/CategoryService.java > 1508804 > > /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/PortalPreferenceService.java > 1508804 > > /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/RegionService.java > 1508804 > > /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/RegionWidgetService.java > 1508804 > > /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/TagService.java > 1508804 > > /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/UserService.java > 1508804 > > /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/WidgetService.java > 1508804 > > /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/impl/DefaultCategoryService.java > 1508804 > > /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/impl/DefaultPortalPreferenceService.java > 1508804 > > /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/impl/DefaultRegionService.java > 1508804 > > /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/impl/DefaultRegionWidgetService.java > 1508804 > > /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/impl/DefaultTagService.java > 1508804 > > /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/impl/DefaultUserService.java > 1508804 > > /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/impl/DefaultWidgetService.java > 1508804 > > /trunk/rave-components/rave-core/src/main/java/org/apache/rave/rest/impl/DefaultCategoriesResource.java > 1508804 > > /trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/service/impl/DefaultCategoryServiceTest.java > 1508804 > > /trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/service/impl/DefaultPortalPreferenceServiceTest.java > 1508804 > > /trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/service/impl/DefaultRegionServiceTest.java > PRE-CREATION > > /trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/service/impl/DefaultRegionWidgetServiceTest.java > 1508804 > > /trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/service/impl/DefaultTagServiceTest.java > 1508804 > > /trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/service/impl/DefaultUserServiceTest.java > 1508804 > > /trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/service/impl/DefaultWidgetServiceTest.java > 1508804 > > /trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/api/rest/WidgetApi.java > 1508804 > > /trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/api/rpc/WidgetApi.java > 1508804 > > /trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/WidgetStoreController.java > 1508804 > > /trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/admin/CategoryController.java > 1508804 > > /trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/admin/UserController.java > 1508804 > > /trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/admin/WidgetController.java > 1508804 > > /trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/api/rest/WidgetApiTest.java > 1508804 > > /trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/controller/WidgetStoreControllerTest.java > 1508804 > > /trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/controller/admin/CategoryControllerTest.java > 1508804 > > /trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/controller/admin/UserControllerTest.java > 1508804 > > /trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/controller/admin/WidgetControllerTest.java > 1508804 > > Diff: https://reviews.apache.org/r/13111/diff/ > > > Testing > ------- > > > Thanks, > > Daniel Gornstein > >
