On Sat, Aug 3, 2013 at 8:22 AM, Matt Franklin <[email protected]>wrote:
> On Wed, Jul 31, 2013 at 10:44 AM, Erin Noe-Payne > <[email protected]>wrote: > > > On Wed, Jul 31, 2013 at 8:26 AM, Gornstein, Daniel S. > > <[email protected]> wrote: > > > All, > > > > > > Quick question about the UserService. > > > > > > We added getAll, getCountAll, and getLimitedList for both the User and > > Person repositories. There does not seem to be a PersonService, however > > there are some methods already in the User service > (getLimitedListOfPersons > > and getLimitedListOfUsers) which support getting limited lists. > > > > > > I am going to be adding getAll, and getCountAll for users, but my > > question is do the methods for Persons belong in the UserService? Should > we > > split it out so there is a separate PersonService? > > > > > > > I don't think so. User service should delegate to the user repository > > methods. I'm not 100% clear on the relationship between person and > > user - I think it has to do with keeping rave users and shinding > > person objects in sync? ... but I don't think we need a person > > service. > > > > The current Person/User concepts are too tightly coupled (User Extends > Person). IMO, we want to start to move toward a model where User > represents only the attributes of the system user necessary to do > authentication and authorization and Person contains all other attributes. > Therefore, a Person service does make sense. > > +1 > > > > > > Thanks, > > > Daniel Gornstein > > >
