-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13684/#review25355
-----------------------------------------------------------



/trunk/rave-components/rave-core-api/src/main/java/org/apache/rave/rest/model/RegionWidget.java
<https://reviews.apache.org/r/13684/#comment49736>

    So when someone goes to create/update a region widget and sets this field, 
will it be propagated back to the widget and saved (probably really bad)? Will 
a new field be added to the RegionWidget table? Or will it just be ignored?
    
    My assumption is it's just ignored right now. Are there other cases in the 
REST API where we just ignore fields? How are we documenting that?


- Chris Geer


On Aug. 20, 2013, 3:25 p.m., Daniel Gornstein wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13684/
> -----------------------------------------------------------
> 
> (Updated Aug. 20, 2013, 3:25 p.m.)
> 
> 
> Review request for rave.
> 
> 
> Repository: rave
> 
> 
> Description
> -------
> 
> This will add the regionWidgetTitle to the REST model for RegionWidgests. The 
> only time it will get filled in is when preparing a regionWidget for render 
> through the pagesForRender resource.
> 
> 
> Diffs
> -----
> 
>   
> /trunk/rave-components/rave-core-api/src/main/java/org/apache/rave/rest/model/RegionWidget.java
>  1513807 
>   
> /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/web/renderer/impl/DefaultRenderService.java
>  1513807 
> 
> Diff: https://reviews.apache.org/r/13684/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Daniel Gornstein
> 
>

Reply via email to