-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13857/#review25620
-----------------------------------------------------------



/branches/angular/rave-portal-resources/src/main/webapp/static/script/portal/controllers/AddOrEditNewPageModalCtrl.js
<https://reviews.apache.org/r/13857/#comment50098>

    If you are adding a page, then it will get pushed into scope pages. 
However, if you are editing a page it looks like the saved changes will not 
propagate back to the in-memory model on pages.


- Erin Noe-Payne


On Aug. 27, 2013, 3:11 p.m., Rohit Kalkur wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13857/
> -----------------------------------------------------------
> 
> (Updated Aug. 27, 2013, 3:11 p.m.)
> 
> 
> Review request for rave.
> 
> 
> Bugs: 1035, 1036 and 1043
>     https://issues.apache.org/jira/browse/1035
>     https://issues.apache.org/jira/browse/1036
>     https://issues.apache.org/jira/browse/1043
> 
> 
> Repository: rave
> 
> 
> Description
> -------
> 
> The following patch contains the beginning implementation of the CurrentPage 
> and Tabs views/controllers in the portal context of the RAVE Angular branch. 
> It has most of the basic functionality for the RAVE tabs and current page 
> (Edit page, delete page, add page). Also added in an Angular Resource for 
> PageLayouts in order to retrieve page layout information from the REST API.
> 
> 
> Diffs
> -----
> 
>   
> /branches/angular/rave-portal-resources/src/main/webapp/static/html/portal/index.html
>  1517838 
>   
> /branches/angular/rave-portal-resources/src/main/webapp/static/html/portal/tabs.html
>  1517838 
>   
> /branches/angular/rave-portal-resources/src/main/webapp/static/script/common/resources/PageLayoutsResource.js
>  PRE-CREATION 
>   
> /branches/angular/rave-portal-resources/src/main/webapp/static/script/common/resources/index.js
>  1517838 
>   
> /branches/angular/rave-portal-resources/src/main/webapp/static/script/portal/controllers/AddOrEditNewPageModalCtrl.js
>  PRE-CREATION 
>   
> /branches/angular/rave-portal-resources/src/main/webapp/static/script/portal/controllers/CurrentPageCtrl.js
>  PRE-CREATION 
>   
> /branches/angular/rave-portal-resources/src/main/webapp/static/script/portal/controllers/MovePageModalCtrl.js
>  PRE-CREATION 
>   
> /branches/angular/rave-portal-resources/src/main/webapp/static/script/portal/controllers/TabsCtrl.js
>  PRE-CREATION 
>   
> /branches/angular/rave-portal-resources/src/main/webapp/static/script/portal/controllers/index.js
>  1517838 
>   
> /branches/angular/rave-portal-resources/src/main/webapp/static/script/portal/main.js
>  1517838 
> 
> Diff: https://reviews.apache.org/r/13857/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Rohit Kalkur
> 
>

Reply via email to