I think you need to. Both the review board and svn are barfing on me pretty hard when I try to view or apply.
On Thu, Sep 12, 2013 at 2:06 PM, Michael Jett <[email protected]> wrote: > > >> On Sept. 12, 2013, 4:32 p.m., Erin Noe-Payne wrote: >> > Mike, is this patch meant for trunk or angular branch? It does not apply >> > cleanly to trunk. >> >> Erin Noe-Payne wrote: >> In trunk I think it only needs the change to >> /rave-portal-resources/src/main/webapp/static/script/requireConfig.js > > It's for both trunk and angular. The main.js file should exist in trunk so > ignore it. I can create a separate patch if necessary. > > > - Michael > > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14107/#review26053 > ----------------------------------------------------------- > > > On Sept. 12, 2013, 4:21 p.m., Michael Jett wrote: >> >> ----------------------------------------------------------- >> This is an automatically generated e-mail. To reply, visit: >> https://reviews.apache.org/r/14107/ >> ----------------------------------------------------------- >> >> (Updated Sept. 12, 2013, 4:21 p.m.) >> >> >> Review request for rave. >> >> >> Bugs: RAVE-1049 >> https://issues.apache.org/jira/browse/RAVE-1049 >> >> >> Repository: rave >> >> >> Description >> ------- >> >> Added an option to extend wait timeout. >> >> >> Diffs >> ----- >> >> /trunk/rave-portal-resources/src/main/webapp/static/script/portal/main.js >> 1522598 >> >> /trunk/rave-portal-resources/src/main/webapp/static/script/requireConfig.js >> 1522598 >> >> /trunk/rave-providers/rave-opensocial-provider/rave-opensocial-client/src/main/java/org/apache/rave/provider/opensocial/config/OpenSocialEnvironment.java >> 1522598 >> >> Diff: https://reviews.apache.org/r/14107/diff/ >> >> >> Testing >> ------- >> >> >> Thanks, >> >> Michael Jett >> >> >
