----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17356/#review32872 -----------------------------------------------------------
Ship it! I don't think there is much we can do about the ugliness at this stage. - Matt Franklin On Jan. 25, 2014, 11:40 p.m., Stanton Sievers wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17356/ > ----------------------------------------------------------- > > (Updated Jan. 25, 2014, 11:40 p.m.) > > > Review request for rave. > > > Bugs: RAVE-1086 > https://issues.apache.org/jira/browse/RAVE-1086 > > > Repository: rave > > > Description > ------- > > Using the DefaultPageService.clonePageForUser API does not clone any subpages > that may exist on the page being cloned. > > I've added functionality to look through the subpages and clone them as well. > This is not recursive, so subpages of subpages won't be cloned... if that's > even possible or a use case Rave wants to support. > > I'll admit, this is messy. There's not a good way to efficiently read/update > subpages. A common pattern is to find a page given a subpage and then having > to iterate through all of the subpages to find the one for which the page was > retrieved. If anyone has any better ideas on how to do this I'd be happy to > hear them. > > > Diffs > ----- > > > https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/impl/DefaultPageService.java > 1561424 > > https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/service/impl/DefaultPageServiceTest.java > 1561424 > > https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-mongodb/src/main/java/org/apache/rave/portal/repository/impl/MongoDbRegionRepository.java > 1561424 > > Diff: https://reviews.apache.org/r/17356/diff/ > > > Testing > ------- > > Updated existing unit tests. Tested page cloning operations for pages with > subpages in a custom portal. Tested normal page cloning operations in the > default Rave portal. > > > Thanks, > > Stanton Sievers > >
