----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17358/#review32875 -----------------------------------------------------------
Ship it! Ship It! - Matt Franklin On Jan. 26, 2014, 12:36 a.m., Stanton Sievers wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17358/ > ----------------------------------------------------------- > > (Updated Jan. 26, 2014, 12:36 a.m.) > > > Review request for rave. > > > Bugs: RAVE-1090 > https://issues.apache.org/jira/browse/RAVE-1090 > > > Repository: rave > > > Description > ------- > > If a page is cloned for the current user (which can be done via the REST APIs > but not the current Share Page UI) the user is prompted to Accept/Decline the > page on first render. > > The fix is to check and see if the current authenticated user is the user for > which the page is being cloned. If they are the same, set the page user > status to "owned" instead of "pending". > > > Diffs > ----- > > > https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/impl/DefaultPageService.java > 1561424 > > Diff: https://reviews.apache.org/r/17358/diff/ > > > Testing > ------- > > Existing unit tests pass. > > Verified that cloning a page for another user still results in the prompt > upon rendering the page. Verified via Postman that cloning the page for the > authenticated user results in no prompt upon first render of the page. > > It's worth noting that I was having problems cloning pages with more than one > region in the default portal. Things worked as expected with a single column > page layout where there is only one region. Is this known behavior? I did > not encounter it when working on RAVE-1086. I encountered it even without > this or any other patches. > > > Thanks, > > Stanton Sievers > >
