-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18216/
-----------------------------------------------------------
(Updated Feb. 19, 2014, 5:11 p.m.)
Review request for rave.
Changes
-------
Avoiding infinite recursion when serializing a page with subpages. Ensuring a
page's list of subpages is always non-null.
Bugs: RAVE-1092
https://issues.apache.org/jira/browse/RAVE-1092
Repository: rave
Description
-------
When cloning a page, the PageApi and PageService will now return the Page
object itself.
Diffs (updated)
-----
https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/impl/PageImpl.java
1569485
https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/PageService.java
1569485
https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/impl/DefaultPageService.java
1569485
https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/service/impl/DefaultPageServiceTest.java
1569485
https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/api/rpc/PageApi.java
1569485
Diff: https://reviews.apache.org/r/18216/diff/
Testing
-------
Existing unit tests pass. Added a new unit test to sanity check the returned
value.
Verified that page cloning works in the default portal and that the REST call
returns the correct page object.
There's definitely more unit testing that needs to be done around the page
cloning API.
Thanks,
Stanton Sievers
