To be clear, this is an open invitation to anyone in the community. If you would like to participate, e-mail me directly.
This is also NOT a normal operating practice. In the future, everyone please submit small, independent patches rather than one monolithic PR. Also, no decisions should be made during the code review. Any questions or decision points will be brought back to the list for everyone to weigh in on. On Mon, Aug 25, 2014 at 9:22 AM, Jmeas Apache <[email protected]> wrote: > Hey everyone, > > Per Matt Franklin's comment here > <https://github.com/apache/rave/pull/7#issuecomment-53261305>, I'm > inviting > all of you to a code review session to review that big PR that's waiting to > be merged into Rave. > > We'll step through the changes, you can ask any questions you might have, > and you can learn about the updated Angular code. > > I'm thinking of having the code review on Wednesday at 1pm. If you're an > invested contributor to Rave, and this time doesn't work out for you, just > say the word. I'm flexible on the time, and I all but picked it at random. > > Some tidbits: > > – It's (optionally) built with Vagrant and Ansible on a sandboxed VM. Feel > free to try to set that up if you're interested. > > – The code changes are 100% standalone from what currently exists in the > Rave project. In fact, it will *always* be merge conflict-free as the work > is done in a brand new directory, */rave-portal-ng* > > – The focus of these code changes were on converting the entire webapp over > to Angular, whereas the original Angular branch was attempting to convert a > subset of the app to Angular (namely, the home page with the widgets). This > conversion is complete – the webapp now functions standalone, interacting > only with the Java backend for API endpoints. > > – The only completed section of the new webapp is the admin area, so > there's not much to see on the home page, profile page, or widgets page. > > – The new webapp uses a mock, client-side API, written in > Javascript/Angular, for the endpoints that we needed. This allowed us, and > future developers, to quickly iterate on new endpoints for the client > without having a backend/Java dependency. > > We'll go over all of this and more during the code review. Hope to see you > there! > > James >
