This is an automated email from the ASF dual-hosted git repository.

junchao pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-resilientdb.git


The following commit(s) were added to refs/heads/master by this push:
     new 43a30b35 Fix the failure memory order argument to 
atomic_compare_exchange_strong_explicit
     new 295d1b99 Merge pull request #126 from AtariDreams/patch-1
43a30b35 is described below

commit 43a30b35ee8e42055b413168810d2af83bc9c50a
Author: AtariDreams <83477269+ataridre...@users.noreply.github.com>
AuthorDate: Wed Dec 20 15:18:43 2023 -0500

    Fix the failure memory order argument to 
atomic_compare_exchange_strong_explicit
    
    The failure memory order cannot be release or acq_rel. Clang since 
llvm/llvm-project@fed5644 diagnoses an invalid argument.
---
 platform/common/queue/lock_free_queue.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/platform/common/queue/lock_free_queue.h 
b/platform/common/queue/lock_free_queue.h
index c8e05593..1bbfe249 100644
--- a/platform/common/queue/lock_free_queue.h
+++ b/platform/common/queue/lock_free_queue.h
@@ -41,7 +41,7 @@ class LockFreeQueue {
       bool old_v = true;
       if (need_notify_.compare_exchange_strong(old_v, false,
                                                std::memory_order_acq_rel,
-                                               std::memory_order_acq_rel)) {
+                                               std::memory_order_acquire)) {
         std::lock_guard<std::mutex> lk(mutex_);
         cv_.notify_all();
         return;

Reply via email to