Thanks for the help. Best, Junchao
On Wed, Jul 10, 2024 at 7:11 PM Mohammad Sadoghi <msado...@expolab.org> wrote: > Dear JB > > Thank you so much for detailed review. Greatly appreciated. > > Best Regards, > Mohammad Sadoghi, PhD > Associate Professor > Exploratory Systems Lab (ExpoLab) > Department of Computer Science > University of California, Davis > > > On Wed, Jul 10, 2024 at 4:09 AM Jean-Baptiste Onofré <j...@nanthrax.net> > wrote: > > > Hi folks > > > > I did a quick tour on our NOTICE, LICENSE, and DISCLAIMER-WIP files. > > > > - DISCLAIMER-WIP > > The file is OK, containing the regular disclaimer statements. > > > > - LICENSE and NOTICE > > It's OK. LICENSE looks good to me, mentioning the third party and their > > license. > > For the NOTICE, it's OK. I think that to fully comply with ASL 2.0 > > 4(d) section, we can include third party mentions in the NOTICE file. > > > > So, no blocker for the release, just good to have improvements for the > > next release. > > I will create a PR about the NOTICE file improvements. > > > > Thanks ! > > Regards > > JB > > >
