Here's a fix:

https://github.com/apache/incubator-ripple/pull/42

Thanks,

Tim

-----Original Message-----
From: Tim Barham [mailto:[email protected]] 
Sent: Thursday, March 5, 2015 5:42 PM
To: [email protected]
Subject: RE: Cordova Android 4.0 platform renames "App" plugin to "CoreAndroid"

Actually thinking about this further, creating platform/cordova/4.0.0 is 
probably not needed for this. The change in Cordova is specific to the Android 
platform, and is independent of the Cordova version. I think I'll leave App as 
it is and add CoreAndroid in 3.0.0 (initial implementation will be identical to 
App, but any changes going forward will be in CoreAndroid).

-----Original Message-----
From: Tim Barham [mailto:[email protected]] 
Sent: Thursday, March 5, 2015 5:00 PM
To: [email protected]
Subject: Cordova Android 4.0 platform renames "App" plugin to "CoreAndroid"

In the 4.0 version of the Cordova Android platform, the built-in App plugin has 
been renamed CoreAndroid. Ripple will need to be updated to handle this change.

A fairly simple way to handle it in a backwards compatible manner would be to 
add CoreAndroid as a synonym for App in 
lib/client/platform/cordova/2.0.0/bridge.js:

emulator = {
    "App": ripple('platform/cordova/2.0.0/bridge/app'),
    "CoreAndroid": ripple('platform/cordova/2.0.0/bridge/app'),
    "Accelerometer": ripple('platform/cordova/2.0.0/bridge/accelerometer'),
    "Battery" : ripple('platform/cordova/2.0.0/bridge/battery'),
    "Compass": ripple('platform/cordova/2.0.0/bridge/compass'),
    "Camera": ripple('platform/cordova/2.0.0/bridge/camera'),
    "Capture": ripple('platform/cordova/2.0.0/bridge/capture'),
    "Contacts": ripple('platform/cordova/2.0.0/bridge/contacts'),
    "Debug Console": ripple('platform/cordova/2.0.0/bridge/console'),
    "Device": ripple('platform/cordova/2.0.0/bridge/device'),
    "File": ripple('platform/cordova/2.0.0/bridge/file'),
    "Geolocation": ripple('platform/cordova/2.0.0/bridge/geolocation'),
    "Globalization": ripple('platform/cordova/2.0.0/bridge/globalization'),
    "Logger": ripple('platform/cordova/2.0.0/bridge/logger'),
    "Media": ripple('platform/cordova/2.0.0/bridge/media'),
    "Network Status": ripple('platform/cordova/2.0.0/bridge/network'),
    "NetworkStatus": ripple('platform/cordova/2.0.0/bridge/network'),
    "Notification": ripple('platform/cordova/2.0.0/bridge/notification')
};

However, I guess that's not ideal going forwards. Should we create 
platform/cordova/4.0.0 and add CoreAndroid support there?

Tim

Reply via email to