I found the following issues: NOTICE -> 2012 :)
pkg/hosted/ripple.js appears to be empty. Is that correct? pkg/hosted do not have license headers. It looks like this would generated code, which is uploaded to somewhere? In Java-terms it would be similar to a binary artifact, which also do not have headers. This might come up as an issue. At Apache we are releasing source code first, everything else is just nice. The best and easiest thing would be to just add the header (automatically) to that files. Are there any options? /assets/server/images/NOTICE: its in a folder where only the logo remains. Is the location intended? I see a lot of images in /pkg/hosted/images, but no NOTICE there Maybe the included message should just go to the global NOTICE file? Thanks, i feel we are close :) Christian -- Christian Grobmeier http://www.grobmeier.de http://www.timeandbill.de On Tue, Mar 10, 2015, at 15:14, Tim Barham wrote: > Please review and vote on the release of Ripple 0.9.28. > > The package you are voting on is available for review at > http://bit.ly/1FZ8meZ. It was published from its corresponding git tag: > incubator-ripple: 0.9.28 (1d95fed542) > > Since this will be an official Apache release of Ripple (our first!), we > must be particularly careful that it complies with all Apache guidelines > for an incubator release. As such, before voting +1, please refer to and > verify compliance with the checklist at > http://incubator.apache.org/guides/releasemanagement.html#check-list. > > If anyone has concerns that we don't meet any of these requirements, > please don't hesitate to raise them here so we can discuss and make > changes if necessary. > > If you do give a +1 vote, please include what steps you took in order to > be confident in the release. > > Please also note from Ross's recent email: > > > What we need is three +1 "binding" votes, in reality that means three IPMC > > members. Once a project graduates it means three project management > > committee > > members. However, as a mentor (therefore having a binding vote) I look to > > the > > project participants to indicate their preference and (assuming no blocking > > issues on an IP check) I'll always vote in support of the communities non- > > binding votes. > > So please, even though your vote may not be binding, take some time to > review the release and vote! > > Upon a successful vote, we will arrange for the archive to be uploaded to > dist/incubator/ and publish it to NPM. > > Thanks, and looking forward to our first official Ripple release! > > Tim
