Yeah, I verified all the tests pass with the changes Julian proposes, so I agree we should go ahead with that. Of course I have an ulterior motive - some changes I'm currently working on (dev only) require at least Node 0.11.12, so I'd like to update our Node requirement :).
> > Also, Ripple's package.json contains version references using the caret > > notation. > > I am a proponent of just freezing all the versions, to fix this, and to > keep things consistent. ? If we move to a newer version of node and npm, is there a reason to avoid the caret notation? That means we should only get backwardly compatible versions (yeah, I know, I'm sure not everyone is rigorous about sticking to that), and we gain the advantage of potentially getting bug fixes. Tim -----Original Message----- From: Brent Lintner [mailto:[email protected]] Sent: Tuesday, April 21, 2015 6:11 AM To: [email protected] Subject: Re: What version of node.js does Ripple require? Ah! Thanks a bunch Julian!! I had noticed this with future versions but didn't have a chance to look in depth. :-( >> Is there any reason I shouldn't upstream this change? IMO, if things are all good and `jake test` runs smoothly, then, please do! :-D >> Also, Ripple's package.json contains version references using the caret notation. I am a proponent of just freezing all the versions, to fix this, and to keep things consistent. ? >> What version of node and npm does Ripple require nowadays. Ideally, the latest, as it used to be assumed (since having such out of date deps being left :-S). On Mon, 20 Apr 2015 at 13:26 Horn, Julian C <[email protected]> wrote: > What version of node and npm does Ripple require nowadays? > The README just says node and npm are required, but it doesn't say > anything about versions. > > There are some known compatibility issues between modules used by Ripple > and newer versions of node. > Specifically, jsdom is pegged to version 0.6.x (0.6.5) in the package.json > and this doesn't work with node 0.11.x. > You get this error when you run "jake test": > > RangeError: The normalization form should be one of NFC, NFD, NFKC, NFKD. > > See https://github.com/tmpvar/jsdom/issues/769 for more details. > > Also, Ripple's package.json contains version references using the caret > notation. > This means older versions of npm don't work. > If you install the pre-built installer for node 0.10.5, you get npm > version 1.2.18 and it doesn't do carets. > This means the configure script will fail unless you explicitly update > your npm version. > > I got node versions 0.11.15 and 0.12.0 to work, after I upgraded the jsdom > version from 0.6.x to 3.0.1 in the package.json. > Is there any reason I shouldn't upstream this change? > > > > > > >
