[ 
https://issues.apache.org/jira/browse/RIPPLE-74?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14529941#comment-14529941
 ] 

Tim Barham edited comment on RIPPLE-74 at 5/6/15 5:33 AM:
----------------------------------------------------------

I've taken a look at this, and the issue is two-fold.

First, for the Android platform, the geolocation plugin no longer patches 
navigator.geolocation - it simply lets it fall through to the platform 
implementation. So Ripple's logic for intercepting cordova.exec doesn't catch 
this even when the plugin is installed. If you switch Ripple to a device that 
uses a different Cordova platform (like an iOS device, for example), then 
Ripple's geolocation emulation works (provided the plugin is installed).

The second part of the problem is that Ripple actually patches 
navigator.geolocation directly - it is suppoed to work even if the plugin is 
not installed. However, that logic fails - Ripple sets window.navigator 
directly, which doesn't work. I have a fix which I'll check in shortly.


was (Author: timbarham):
I've taken a look at this, and the issue is two-fold.

First, for the Android platform, the geolocation plugin no longer patches 
navigator.geolocation - it simply lets it fall through to the platform 
implementation. So Ripple's logic for intercepting cordova.exec doesn't catch 
this even when the plugin is installed. If you switch Ripple to a device that 
uses a different Cordova platform (like an iOS device, for example), then 
Ripple's geolocation emulation works (provided the plugin is installed).

The second part of the problem is that Ripple actually patches 
navigator.geolocation directly - it is suppoed to work even if the plugin is 
not installed. However, that logic is fails - Ripple sets window.navigator 
directly, which doesn't work. I have a fix which I'll check in shortly.

> ripple does not pass geolocation info to app
> --------------------------------------------
>
>                 Key: RIPPLE-74
>                 URL: https://issues.apache.org/jira/browse/RIPPLE-74
>             Project: Apache Ripple
>          Issue Type: Bug
>         Environment: Win7, i7 hardware, Chrome Version 37.0.2062.124 m
>            Reporter: Peter Lindstrom
>
> my app utilizes 
> navigator.geolocation.getCurrentPosition(placemarks_geolocation_callback() 
> but regardless of what i enter in the ripple geolocation settings this call 
> only returns my local geo coordinates.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to