We have a number of uses of internal sun impl classes, I'd agree they should 
all be replaced so we can expand beyond the sun implementation.  Is there a 
related jira?

If you can see a simple fix eliminating the sun dependency, go for it, 
otherwise I think just fix it enough to get our release out.

I hadn't given it further consideration last time I looked.

Cheers,

Peter.

----- Original message -----
> I think the problem may go deeper. sun.net.spi.nameservice.NameService
> is a sun.net interface that can change from version to version. Is it
> essential that we have our own implementation?
>
> Patricia
>
>
> On 6/28/2011 12:18 AM, Peter wrote:
> > Oops, I fixed that but didn't commit, sorry  Not near my dev box, but the 
> > fix
> > is relatively simple, get byte array from each InetAddress, and return
> > byte[][] instead, can someone fix it?
> >
> > ----- Original message -----
> > > I downloaded the source, and tried a naive build on Windows XP, Cygwin.
> > > I put a JDK 1.5 bin directory at the start of my path, and ran "ant
> > > all.build". It failed with the following errors:
> > >
> > > compile:
> > >                      [javac] Compiling 1993 source files to C:\Documents 
> > >and
> > > Settings\Administrator\My
> > > Documents\River_2.2\apache-river-2.2.0-src\apache-river-2.2.0\qa\build\classes
> > >                      [javac] C:/Documents and Settings/Administrator/My
> > > Documents/River_2.2/apache-river-2.2.0-src/apache-river-2.2.0/qa/src/com/sun/jini/test/impl/reggie/NameServiceImpl.java:29:
> > > com.sun.jini.test.impl.reggie.NameServiceImpl is not abstract and does
> > > not override abstract method lookupAllHostAddr(java.lang.String) in
> > > sun.net.spi.nameservice.NameService
> > >                      [javac] public class NameServiceImpl implements 
> > >NameService {
> > >                      [javac]                          ^
> > >                      [javac] C:/Documents and Settings/Administrator/My
> > > Documents/River_2.2/apache-river-2.2.0-src/apache-river-2.2.0/qa/src/com/sun/jini/test/impl/reggie/NameServiceImpl.java:42:
> > > lookupAllHostAddr(java.lang.String) in
> > > com.sun.jini.test.impl.reggie.NameServiceImpl cannot implement
> > > lookupAllHostAddr(java.lang.String) in
> > > sun.net.spi.nameservice.NameService; attempting to use incompatible
> > > return type
> > >                      [javac] found      : java.net.InetAddress[]
> > >                      [javac] required: byte[][]
> > >                      [javac]              public InetAddress[] 
> > >lookupAllHostAddr(String host)
> > >                      [javac]                                              
> > >                                                    ^
> > >                      [javac] Note: Some input files use or override a 
> > >deprecated API.
> > >                      [javac] Note: Recompile with -Xlint:deprecation for 
> > >details.
> > >                      [javac] Note: Some input files use unchecked or 
> > >unsafe operations.
> > >                      [javac] Note: Recompile with -Xlint:unchecked for 
> > >details.
> > >                      [javac] 2 errors
> > >
> > > (I'm not worried about the deprecated APIs, just the compile failures.)
> > >
> > > I next tried to find instructions. I looked at
> > > src-doc/static/build.html. It says "The bin directory of the Java(TM) 2
> > > SDK, Standard Edition, v 1.4 (or later) must be in your executable
> > > search path."
> > >
> > > I believe we now need 1.5 or later.
> > >
> > > Patricia
> > >
> > >
> >
> >
>

Reply via email to