On 22/11/2012 8:22 PM, Simon IJskes - QCG wrote:
On 22-11-12 11:16, Dan Creswell wrote:
See, if it wasn't on trunk, the changes would be less of a big deal.
It'd
be natural to check one's work in (whether it be an in-progress test
snapshot or otherwise), good discipline even.
Yes. I would have branched trunk, copied a jenkins job, and
experimented on it. If something good would come out of it, it would
probably be small, and easily patchable on trunk.
I might remind you Sim, that recent evidence demonstrates you didn't
make this choice.
I'll put this in context for you, I left trunk in a stable passing state
in late August. These tests from 16th of August through to 5th of
September show that:
https://builds.apache.org/view/M-R/view/River/job/River-QA-windows/54/
https://builds.apache.org/view/M-R/view/River/job/River-QA-solaris/60/
https://builds.apache.org/view/M-R/view/River/job/River-QA-ubuntu-jdk6/130/
https://builds.apache.org/view/M-R/view/River/job/River-QA-ubuntu-jdk7/52/
This was also the first time that River has passed on the Windows
platform, if you don't believe me, try running the qa tests on windows
with the previous release. As far as I was concerned, the codebase was
almost ready for release, the release version needed incrementing and
documentation updated.
But Sim, you developed in trunk without running the qa test suite, you
must run these tests every time you make changes, that way you know
which change caused the breakage. Did you run the jtreg regression test
suite?
This is what happened:
When I returned, I found most Jenkins tests disabled, then I ran them
and found many failing tests.
https://builds.apache.org/view/M-R/view/River/job/River-QA-ubuntu-jdk7/55/consoleText
[java] -----------------------------------------
[java]
[java] # of tests started = 1411
[java] # of tests completed = 1411
[java] # of tests skipped = 47
[java] # of tests passed = 1268
[java] # of tests failed = 143
[java]
[java] -----------------------------------------
[java]
[java] Date finished:
[java] Mon Oct 29 18:30:08 UTC 2012
[java] Time elapsed:
[java] 61854 seconds
[java]
[java] Java Result: 1
I have now fixed most failing tests, I have done so remotely without
access to debugging tools and also without criticising any other
developers, I've also just taken the opportunity to fix 283 failing
tests on arm.
Apportioning blame doesn't fix problems. I had made the mistake of
developing directly in trunk myself some time back, so I refrained from
dispensening criticism.
Would you like me to go on?
You have two options:
1. Work as a team, lets get trunk stable again and ready for release.
2. Continue the pissing contest.
The balls in your court.
Peter.
