On 27/11/2012 8:19 PM, Simon IJskes - QCG wrote:
I see a lot of changes to RegistrarImpl.

Was RegistrarImpl really that broken?

No.

What errors have been fixed by moving the places the threads were started?

None.

What errors have been fixed by converting the collections, and making variables final?

None.

What errors have been fixed by changing the Socket handling?

None.

Gr. Sim


When faced with difficult concurrency problems, I've had success in the past by refactoring. Trouble with concurrency bugs; you can't always tell where they are, consider it a brute force debugging attempt, sometimes it pays off.

If you prefer ReggieImpl how it was previously we can change it back after all tests are passing.

Regards,

Peter.


Reply via email to