The changes in RIVER-445 remove the activation system and the JRMP exporter, and associated QA tests, which is a change to the public API. Our conventions require a vote on changes to the public API. Since we’ve discussed the intent of these changes previously (and had general agreement), I think it’s appropriate to call a vote on the patch immediately.
The vote will remain open until at least 0000 UTC Dec 1 (that’s more than 72 hours, but our American friends have Thanksgiving and Black Friday to contend with). It’s a lazy-consensus vote, however according to Apache conventions on voting for code changes, any ‘-1’ votes constitute a veto.If there are no ‘-1’ votes by Monday evening, I’ll apply the patch to the 2.2 branch. +1: [ ] I am in favour of this proposal +0: [ ] I am not opposed to this proposal -1: [ ] I am opposed (please provide an explanation) Cheers, Greg Trasuk > On Nov 25, 2015, at 10:54 PM, Greg Trasuk (JIRA) <j...@apache.org> wrote: > > > [ > https://issues.apache.org/jira/browse/RIVER-445?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel > ] > > Greg Trasuk updated RIVER-445: > ------------------------------ > Attachment: river-2.2-remove-activation.diff > >> Remove the Activation subsystem and JRMP support >> ------------------------------------------------ >> >> Key: RIVER-445 >> URL: https://issues.apache.org/jira/browse/RIVER-445 >> Project: River >> Issue Type: Improvement >> Affects Versions: River_2.2.2 >> Reporter: Greg Trasuk >> Assignee: Greg Trasuk >> Attachments: river-2.2-remove-activation.diff >> >> >> As discussed on the dev@river.apache.org mailing list (first message >> http://mail-archives.apache.org/mod_mbox/river-dev/201511.mbox/%3C0B80457A-85EB-4D91-92B7-8294A9B82D5B%40trasuk.com%3E), >> the attached patch removes the activation subsystem and the JRMP exporter >> support, so as to reduce the maintenance effort for seldom-used code. >> There are several changes to the QA tests. The logic of the tests was not >> changed, only the 'if'-blocks and associated methods that supported >> activation were removed. The QA package runs successfully (tested under >> MacOS 10.11.1 running java version "1.8.0" >> Java(TM) SE Runtime Environment (build 1.8.0-b128) >> Java HotSpot(TM) 64-Bit Server VM (build 25.0-b69, mixed mode)) > > > > -- > This message was sent by Atlassian JIRA > (v6.3.4#6332)
