dongeforever commented on a change in pull request #127: [ROCKETMQ-233] Fix
pull interval issue
URL: https://github.com/apache/rocketmq/pull/127#discussion_r156645862
##########
File path:
client/src/main/java/org/apache/rocketmq/client/consumer/DefaultMQPushConsumer.java
##########
@@ -231,6 +234,7 @@ public DefaultMQPushConsumer(final String consumerGroup,
RPCHook rpcHook, Alloca
this.consumerGroup = consumerGroup;
this.allocateMessageQueueStrategy = allocateMessageQueueStrategy;
defaultMQPushConsumerImpl = new DefaultMQPushConsumerImpl(this,
rpcHook);
+ this.pullIntervalPolicy = new
BoundedExponentialPullIntervalPolicy(100, 300000);
}
Review comment:
300s is too long.
For SUB latency-sensitive applications, long polling is suggested.
So fix pull interval policy is suggested, and the default pull interval
should be zero.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
