lindzh opened a new pull request #208: [ROCKETMQ-336] Wrong format 
System.out.printf used in mqadmin
URL: https://github.com/apache/rocketmq/pull/208
 
 
   ## What is the purpose of the change
   
   When using mqadmin command printmsg to print retry topic msgs,it throw an 
exception like this:
   com.alibaba.rocketmq.client.exception.MQClientException: Can not find 
Message Queue for this
   
   ```
   topic, %%RETRY%%CID_MERSS_CONSUOUP_UAT
   See http://rocketmq.apache.org/docs/faq/ for further details.
     at 
com.alibaba.rocketmq.client.impl.MQAdminImpl.fetchSubscribeMessageQueues(MQAdminImpl.java:161)
     at 
com.alibaba.rocketmq.client.impl.consumer.DefaultMQPullConsumerImpl.fetchSubscribeMessageQueues(DefaultMQPullConsumerImpl.java:136)
     at 
com.alibaba.rocketmq.client.consumer.DefaultMQPullConsumer.fetchSubscribeMessageQueues(DefaultMQPullConsumer.java:225)
     at 
com.alibaba.rocketmq.tools.command.message.PrintMessageSubCommand.execute(PrintMessageSubCommand.java:120)
     at 
com.alibaba.rocketmq.tools.command.MQAdminStartup.main0(MQAdminStartup.java:128)
   ,. JIRA: https://issues.apache.org/jira/browse/ROCKETMQ-278.
   ```
   
   This problem has been fixed in 
https://github.com/apache/rocketmq/pull/168,but it din't fix all.
   
   ## Brief changelog
   
   fix all system.out.prinf using in rocketmq.
   
   ## Verifying this change
   
   1. This change is a trivial rework / code cleanup with unitout test coverage.
   2. execute mqadmin printmsg -t %RETRY%CID_MERSS_CONSUOUP_UAT.
   
   Follow this checklist to help us incorporate your contribution quickly and 
easily:
   
   - [x] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/projects/ROCKETMQ/issues/) filed for the 
change (usually before you start working on it). Trivial changes like typos do 
not require a JIRA issue. Your pull request should address just this issue, 
without pulling in other changes - one PR resolves one issue. 
   - [x] Format the pull request title like `[ROCKETMQ-XXX] Fix 
UnknownException when host config not exist`. Each commit in the pull request 
should have a meaningful subject line and body.
   - [x] Write a pull request description that is detailed enough to understand 
what the pull request does, how, and why.
   - [ ] Write necessary unit-test to verify your logic correction, more mock a 
little better when cross module dependency exist. If the new feature or 
significant change is committed, please remember to add integration-test in 
[test module](https://github.com/apache/rocketmq/tree/master/test).
   - [x] Run `mvn -B clean apache-rat:check findbugs:findbugs 
checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install 
-DskipITs` to make sure unit-test pass. Run `mvn clean test-compile 
failsafe:integration-test`  to make sure integration-test pass.
   - [x] If this contribution is large, please file an [Apache Individual 
Contributor License Agreement](http://www.apache.org/licenses/#clas).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to