zhouxinyu commented on a change in pull request #219: [ROCKETMQ-355] Client
asyncSend is not fully async
URL: https://github.com/apache/rocketmq/pull/219#discussion_r161971022
##########
File path:
client/src/main/java/org/apache/rocketmq/client/producer/MQProducer.java
##########
@@ -53,11 +51,9 @@ SendResult send(final Message msg, final MessageQueue mq)
throws MQClientExcepti
SendResult send(final Message msg, final MessageQueue mq, final long
timeout)
throws MQClientException, RemotingException, MQBrokerException,
InterruptedException;
- void send(final Message msg, final MessageQueue mq, final SendCallback
sendCallback)
- throws MQClientException, RemotingException, InterruptedException;
+ void send(final Message msg, final MessageQueue mq, final SendCallback
sendCallback);
Review comment:
There is an upgrade issue if the code has catched the thrown
checked-exception, like `MQClientException`.
We should treat this issue carefully ~
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
