zhouxinyu commented on a change in pull request #205: [ROCKETMQ-319] improve 
broker register performance and reduce memory usage  
URL: https://github.com/apache/rocketmq/pull/205#discussion_r171786659
 
 

 ##########
 File path: 
broker/src/main/java/org/apache/rocketmq/broker/processor/AdminBrokerProcessor.java
 ##########
 @@ -310,8 +310,8 @@ private RemotingCommand 
updateBrokerConfig(ChannelHandlerContext ctx, RemotingCo
                     log.info("updateBrokerConfig, new config: [{}] client: {} 
", properties, ctx.channel().remoteAddress());
                     
this.brokerController.getConfiguration().update(properties);
                     if (properties.containsKey("brokerPermission")) {
-                        this.brokerController.registerBrokerAll(false, false);
                         
this.brokerController.getTopicConfigManager().getDataVersion().nextVersion();
+                        this.brokerController.registerBrokerAll(false, 
false,true);
 
 Review comment:
   The same issue.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to