vongosling commented on a change in pull request #205: [ROCKETMQ-319] improve
broker register performance and reduce memory usage
URL: https://github.com/apache/rocketmq/pull/205#discussion_r172421354
##########
File path:
broker/src/main/java/org/apache/rocketmq/broker/out/BrokerOuterAPI.java
##########
@@ -52,6 +62,8 @@
private final RemotingClient remotingClient;
private final TopAddressing topAddressing = new
TopAddressing(MixAll.getWSAddr());
private String nameSrvAddr = null;
+ private BrokerFixedThreadPoolExecutor brokerOuterExecutor = new
BrokerFixedThreadPoolExecutor(4, 10, 1, TimeUnit.MINUTES,
+ new ArrayBlockingQueue<Runnable>(32), new
ThreadFactoryImpl("brokerOutApi_thread_", true));
Review comment:
Why is 32 while not other value, Could you give us some explanation here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
