lizhanhui commented on a change in pull request #312: [ISSUE#311] Improve
broker register topicrouter info performance
URL: https://github.com/apache/rocketmq/pull/312#discussion_r190183861
##########
File path:
broker/src/main/java/org/apache/rocketmq/broker/processor/AdminBrokerProcessor.java
##########
@@ -245,7 +245,10 @@ private RemotingCommand
updateAndCreateTopic(ChannelHandlerContext ctx,
topicConfig.setTopicSysFlag(requestHeader.getTopicSysFlag() == null ?
0 : requestHeader.getTopicSysFlag());
this.brokerController.getTopicConfigManager().updateTopicConfig(topicConfig);
- this.brokerController.registerBrokerAll(false, true, true);
+
+ if (brokerController.getBrokerConfig().getRegisterNameServerPeriod()
== 0) {
+ this.brokerController.registerBrokerAll(false, true, true);
Review comment:
This results in extra complexities to existing users and deployments.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
