lizhanhui commented on issue #227: [ROCKETMQ-332] fix concurrent bug in MappedFileQueue#findMappedFileByOffset, which m… URL: https://github.com/apache/rocketmq/pull/227#issuecomment-392479047 After reviewing the solution, I find the proposing fix is kind of cumbersome. Can we simply introduce a read-write lock to guard the `mappedFiles` list? The collection is definitely read-intensive and should not bring about much overhead when guarded with a read-write lock.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
