vongosling commented on a change in pull request #358: [ISSUE #292] Add support
of transactional message feature
URL: https://github.com/apache/rocketmq/pull/358#discussion_r200930216
##########
File path:
common/src/main/java/org/apache/rocketmq/common/protocol/header/EndTransactionRequestHeader.java
##########
@@ -121,9 +118,14 @@ public void setTransactionId(String transactionId) {
@Override
public String toString() {
- return "EndTransactionRequestHeader [producerGroup=" + producerGroup +
", tranStateTableOffset="
- + tranStateTableOffset + ", commitLogOffset=" + commitLogOffset +
", commitOrRollback="
- + commitOrRollback + ", fromTransactionCheck=" +
fromTransactionCheck + ", msgId=" + msgId
- + "]";
+ return "EndTransactionRequestHeader{" +
Review comment:
ToStringBuilder is easier way to reflect all field in one class
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
