duhengforever commented on a change in pull request #358: [ISSUE #292] Add
support of transactional message feature
URL: https://github.com/apache/rocketmq/pull/358#discussion_r201396417
##########
File path:
broker/src/main/java/org/apache/rocketmq/broker/client/net/Broker2Client.java
##########
@@ -62,34 +60,22 @@ public Broker2Client(BrokerController brokerController) {
}
public void checkProducerTransactionState(
+ final String group,
final Channel channel,
final CheckTransactionStateRequestHeader requestHeader,
- final SelectMappedBufferResult selectMappedBufferResult) {
+ final MessageExt messageExt) throws Exception {
Review comment:
Thanks for your review，in fact，actually I don't want to throw any exceptions
here，but considering that the encode method may cause exception，so in this
method just throws exception following with the encode method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
