lizhanhui commented on issue #358: [ISSUE #292] Add support of transactional message feature URL: https://github.com/apache/rocketmq/pull/358#issuecomment-404985639 1. Newly added classes, member variables & methods should be well documented, explaining their role in your solution. 2. Corner cases are not yet properly handled. For example, if pushing back half message experiences failure, what is the recovering procedure? 3. How is the HA guaranteed in case the master is down? 4. We prefer to use full-word in the identifier, it would be better if this pull request may follow this convention. 5. I am wondering whether the service locator and tx service bridge is an excessive abstraction. IMO, simplicity takes precedence. 6. A lot of the tx related configurations are hard-coded, making them configurable is preferable.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
