duhengforever commented on issue #358: [ISSUE #292] Add support of transactional message feature URL: https://github.com/apache/rocketmq/pull/358#issuecomment-404995102 @lizhanhui thanks for your excellent review firstly. 1. There are comments on the key methods, and the class name directly describes the role of the current class. 2. Some corner cases have been considered and verified，and for the problem of put half message back failed, in fact, we only send a check request after the put back is successful. and if put back failed, we will continue to process this message, and in order to avoid causing unlimited check，we also added the limit of check times for the message, and in this situation, we will also print an error log for easy monitoring and manual processing. 3. In fact, the HA mechanism of the transaction message depends on the HA of the rocketMQ itself. In order to avoid the message not being lost, we recommend using the synchronous double-write mechanism and manually upgrading the slave when the master down. 4. I have been changed the identifier to the full-word. 5. I don't think it's an excessive abstraction, I think transaction message is an application of ordinary message, so I need a bridge to avoid directly manipulating the relevant storage of MQ. 6. Some hard code have been removed, please review the latest commit.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
