Hellojungle closed pull request #421: [ISSUE #411] Fixed ClassCastException
when get the instance of the store
URL: https://github.com/apache/rocketmq/pull/421
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/broker/src/main/java/org/apache/rocketmq/broker/BrokerController.java
b/broker/src/main/java/org/apache/rocketmq/broker/BrokerController.java
index 4ac96c538..eee2f28de 100644
--- a/broker/src/main/java/org/apache/rocketmq/broker/BrokerController.java
+++ b/broker/src/main/java/org/apache/rocketmq/broker/BrokerController.java
@@ -757,12 +757,12 @@ public void shutdown() {
}
if (this.transactionalMessageCheckService != null) {
this.transactionalMessageCheckService.shutdown(false);
+ }
if (this.endTransactionExecutor != null) {
this.endTransactionExecutor.shutdown();
}
}
-
private void unregisterBrokerAll() {
this.brokerOuterAPI.unregisterBrokerAll(
this.brokerConfig.getBrokerClusterName(),
diff --git
a/broker/src/main/java/org/apache/rocketmq/broker/processor/AdminBrokerProcessor.java
b/broker/src/main/java/org/apache/rocketmq/broker/processor/AdminBrokerProcessor.java
index 356aafc46..46362c366 100644
---
a/broker/src/main/java/org/apache/rocketmq/broker/processor/AdminBrokerProcessor.java
+++
b/broker/src/main/java/org/apache/rocketmq/broker/processor/AdminBrokerProcessor.java
@@ -1051,8 +1051,12 @@ private RemotingCommand
ViewBrokerStatsData(ChannelHandlerContext ctx,
final ViewBrokerStatsDataRequestHeader requestHeader =
(ViewBrokerStatsDataRequestHeader)
request.decodeCommandCustomHeader(ViewBrokerStatsDataRequestHeader.class);
final RemotingCommand response =
RemotingCommand.createResponseCommand(null);
+ if (!(this.brokerController.getMessageStore() instanceof
DefaultMessageStore)) {
+ response.setCode(ResponseCode.REQUEST_CODE_NOT_SUPPORTED);
+ response.setRemark(String.format("The ViewBrokerStatsData command
not supported in this messageStore"));
+ return response;
+ }
DefaultMessageStore messageStore = (DefaultMessageStore)
this.brokerController.getMessageStore();
-
StatsItem statsItem =
messageStore.getBrokerStatsManager().getStatsItem(requestHeader.getStatsName(),
requestHeader.getStatsKey());
if (null == statsItem) {
response.setCode(ResponseCode.SYSTEM_ERROR);
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
